Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "build: do not build mksnapshot and mkcodecache for --shared" #30805

Closed
wants to merge 2 commits into from
Closed

Revert "build: do not build mksnapshot and mkcodecache for --shared" #30805

wants to merge 2 commits into from

Conversation

joyeecheung
Copy link
Member

This reverts commit 8cf8eb1.

Refs: nodejs/build#1996

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Dec 5, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27351/

@joyeecheung
Copy link
Member Author

Now even vs2017 is failing...let me try reverting the other commit

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27353/

@joyeecheung
Copy link
Member Author

hmm, nope, still failing.

@joyeecheung joyeecheung closed this Dec 5, 2019
@joaocgreis
Copy link
Member

joaocgreis commented Dec 5, 2019 •
edited
Loading

@joyeecheung thanks for opening this and bringing these changes to my attention!

I'm still trying to figure out the failures. For now I've added a step to clear clcache when the build fails, seems to have fixed CI for the moment.

Given this PR did not seem to fix the issue, this doesn't need to land if that was the only objective. EDIT: outdated GH page, did not see this was closed when commenting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@devnexen devnexen devnexen approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@joyeecheung @nodejs-github-bot @joaocgreis @cjihrig @devnexen